Repository navigation
Directories detected as lockfiles #1177
Description
Lockfile detection believes that directories might be lockfiles.
How To Reproduce
> mkdir requirements.txt
> ls
requirements.txt
> phylum parse
Generating lockfile for manifest "./requirements.txt" using Pip…
❗ Error: Lockfile generation failed! For details, see: https://docs.phylum.io/docs/lockfile-generation
Caused by:
package manager exited with error code 1:
ERROR: Could not open requirements file: [Errno 21] Is a directory: '/path/to/requirements.txt'This error message isn't very helpful....
> mkdir Cargo.lock
> phylum parse
❗ Error: Is a directory (os error 21)
Activity
Ensure lockfiles are files
Ensure lockfiles are files
cd-work commentedon Aug 18, 2023
#1202 as a solution was discarded, since even checking for
!is_directorystill causes syscalls to lookup metadata for every lockfile, even if it doesn't cause failure for the GitHub App. Since this has never caused any issues in practice, there's no reason to slow down the GitHub App.Improve lockfile parsing errors
Improve lockfile parsing errors (#1204)