Skip to content

Extensions: provide PhylumApi mocks for testing extensions through the CLI #450

Description

@andreaphylum

We need to test extensions against API mocks, and figure out whether it is best to try and reuse the mocks already present in other tests or whether we may need to expand those/go in a different direction.

Activity

  1. added this to the Extensions MVP milestone on Jun 8, 2022
  2. kylewillmon commented on Jun 9, 2022

    @kylewillmon
    Contributor

    I'm not sure we need a complete mock here (at least not for MVP). We definitely need a test that executes something with the deno API though (as @cd-work mentioned here)

    Maybe that just means updating our sample extension so that it calls back into the rust code to do something trivial?

  3. added
    medium priorityShould be handled as soon as possible
    extensionsPhylum CLI extensions
    and removed
    needs triageNeeds to be reviewed or assigned
    on Jun 9, 2022
  4. andreaphylum commented on Jun 10, 2022

    @andreaphylum
    ContributorAuthor

    Maybe that just means updating our sample extension so that it calls back into the rust code to do something trivial?

    In this way we can test that we can reach that functionality (which sort of just works anyway) but we won't get a proper idea of the coverage for the serialization layer which is what concerns me -- i.e. having a solid, well-understood and non-surprising translation between V8 types and Rust types so that the API can cooperate effectively. This should also just work on the Rust side but I don't have enough experience with Deno to tell what caveats there may be in forming types on that side.

  5. removed this from the Extensions MVP milestone on Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestextensionsPhylum CLI extensionsmedium priorityShould be handled as soon as possible

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions