unused property (tag) #20

Activity

1. dominykas commented on Feb 12, 2022

   

   dominykas

   on Feb 12, 2022

   Member

   More actions

   Looks like it comes from here:

   nv/index.js

   Lines 166 to 169 in 31c43b9

   	function splitVersion (ver) {
   	const [, major, minor, patch, tag] = /^v([0-9]*)\.([0-9]*)\.([0-9]*)(?:-([0-9A-Za-z-_]+))?/.exec(ver).map((n, i) => i < 4 ? parseInt(n, 10) : n || '')
   	return { major, minor, patch, tag }
   	}

   I guess Node.js never used that, so it may not be necessary, but maybe that code needs to be replaced with semver.parse() anyways, given that semver is already a dep, and return the prerelease prop, however I'm not sure what was the original use case for tag here.

   👍React with 👍1Reacted by Wes Todd
2. wesleytodd

   added 2 commits that reference this issue on Oct 19, 2023

   feat!: tag => prerelease and use semver (#20)

   1b64909

   feat!: tag => prerelease and use semver (#20)

   2798304
3. wesleytodd commented on Oct 19, 2023

   

   wesleytodd

   on Oct 19, 2023

   Member

   More actions

   The tag (now prerelease) is used in canary builds. There is a test which covers this. See #33 for a fix and moving to use semver
4. wesleytodd

   closed this as completedon Oct 19, 2023
5. wesleytodd

   added 2 commits that reference this issue on Jul 16, 2024

   feat!: tag => prerelease and use semver (#20)

   dc3e55d

   feat!: tag => prerelease and use semver (#20)

   ad16081
6. wesleytodd

   added a commit that references this issue on Sep 21, 2025

   feat!: tag => prerelease and use semver (#20)

   2aefa09