Skip to content

Allow for user specified key/values in marks? #152

Closed as not planned
Closed as not planned

Description

@goodboy

Pertaining to the original request in #133 does it make sense to allow users to pass in custom key/val pairs to marks (via **kwargs or some other API) such that user defined collection and/or hook calling behaviour can be controlled/modified by the user based on their own inputs (maybe it's more relatable in the context of #151).

It would potentially look something like:

from pluggy import HookspecMarker

hookspec = HookspecMarker('blah')

@hookspec(historic=True, a_special_hook=True)
def my_special_hook(arg):
    """This hook is only collected in special cases."""
    pass

Activity

  1. RonnyPfannschmidt commented on May 22, 2018

    @RonnyPfannschmidt
    Member

    lets wait for a real problem that needs this

    i'd like to adopt a c4.2-ish approach where we only fix things that has a direct real world impact - abstract feature requests rarely yield a usable api in th first iteration

  2. goodboy commented on May 23, 2018

    @goodboy
    ContributorAuthor

    @RonnyPfannschmidt agreed just thought I'd log it for future reference/discussion.

  3. RonnyPfannschmidt commented on Jun 9, 2020

    @RonnyPfannschmidt
    Member

    i think we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions