You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Allow for user specified key/values in marks? #152
Pertaining to the original request in #133 does it make sense to allow users to pass in custom key/val pairs to marks (via **kwargs or some other API) such that user defined collection and/or hook calling behaviour can be controlled/modified by the user based on their own inputs (maybe it's more relatable in the context of #151).
It would potentially look something like:
frompluggyimportHookspecMarkerhookspec=HookspecMarker('blah')
@hookspec(historic=True, a_special_hook=True)defmy_special_hook(arg):
"""This hook is only collected in special cases."""pass
i'd like to adopt a c4.2-ish approach where we only fix things that has a direct real world impact - abstract feature requests rarely yield a usable api in th first iteration
Activity
RonnyPfannschmidt commentedon May 22, 2018
lets wait for a real problem that needs this
i'd like to adopt a c4.2-ish approach where we only fix things that has a direct real world impact - abstract feature requests rarely yield a usable api in th first iteration
goodboy commentedon May 23, 2018
@RonnyPfannschmidt agreed just thought I'd log it for future reference/discussion.
RonnyPfannschmidt commentedon Jun 9, 2020
i think we can close this one