Skip to content

tracing: store called hook_impls #240

Open
Open
tracing: store called hook_impls#240
Labels
discussionenhancement

Description

@blueyed
blueyed
opened on Nov 14, 2019

With tracing I think it would be good to know where the result is coming from (firstresult=True), and/or which hook_impls have been called in general.

But this could also be useful to know in general, so storing it (optionally?) on the _Result seems like a good idea to me.
It should probably not be full references (except for when tracing is enabled, but that's not easy to know when creating the _Result it seems), but only the plugin_name by default.

Related code:

pluggy/src/pluggy/callers.py

Lines 195 to 198 in a5130ac

if firstresult: # first result hooks return a single value
outcome = _Result(results[0] if results else None, excinfo)
else:
outcome = _Result(results, excinfo)

Activity

  1. blueyed
    added
    enhancement
    discussion
    on Nov 14, 2019

  2. wahuneke commented on Sep 26, 2023

    @wahuneke
    wahuneke
    on Sep 26, 2023
    Contributor

    Is this a dupe of #235 ? Commenting here in order to create a link between the issues

  3. fschulze commented on Jul 7, 2024

    @fschulze
    fschulze
    on Jul 7, 2024
    Contributor

    I think this is indeed a dupe of #235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussionenhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions