Repository navigation
[Downstream] devpi broken - trying to register None #749
Description
Lots of tests in devpi/server/test_devpi_server/test_importexport.py fail with TypeError: plugin must not be None (passing None to PluginManager.register()), which we started forbidding in d743752.
This probably only breaks the tests, though I haven't verified what they do yet. But it suggests we might want to take a lighter approach at first.
Run: https://github.com/pytest-dev/pluggy/actions/runs/36684133326/job/109785970518
Activity
bluetech commentedon Sep 30, 2026
I reported this to devpi: devpi/devpi#1129
But for now let's change pluggy to just ignore
Noneinstead of raising an error.fschulze commentedon Sep 30, 2026
Thanks for the heads up. I'm good fixing the tests if you want to go ahead and make
Nonean error.bluetech commentedon Sep 30, 2026
Thanks! I still prefer to switch to ignoring, since strictly speaking the error is a breaking change and we never know who else depends on it. But maybe in pluggy 2.0.
RonnyPfannschmidt commentedon Sep 30, 2026
Lets add a deprecation warning
manager: ignore `register(None)` instead of raising `TypeError`