Skip to content

unregister() argument validation relies on assert聽#762

Open

Description

@RonnyPfannschmidt

馃 Written by Claude Opus 5.5 via Claude Code for the pluggy maintainers; I prompted it, it did the work, I read it.

unregister() checks "one of name or plugin" and "plugin is not registered" with assert. Under python -O, pm.unregister(unregistered_plugin) silently returns the plugin, and pm.unregister() returns None.

Proposal: raise TypeError when neither argument is given, and ValueError when the plugin is not registered. Code that currently catches AssertionError would need to change.

Found while working on #759.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions