Warn when no specs are used #21

Activity

1. The-Compiler commented on Sep 29, 2015

   

   The-Compiler

   on Sep 29, 2015

   Member

   More actions

   I agree, but I don't think it's the job of pytest-mock to fix this up.

   I plan to write a pylint plugin for this some day, to statically check mocks are always used with spec or autospec.

   I wonder, is there a better mocking library (i.e. with a more sane API) which could be exposed to pytest?
2. RonnyPfannschmidt commented on Sep 29, 2015

   

   RonnyPfannschmidt

   on Sep 29, 2015

   MemberAuthor

   More actions

   There is none, generally mocking is tricky and a sign of bad structure

   I wouldn't want to invent one
3. nicoddemus commented on Sep 29, 2015

   

   nicoddemus

   on Sep 29, 2015

   Member

   More actions

   Hi @RonnyPfannschmidt,

   What do you suggest exactly? If one uses mocker.patch without passing autospec=True or a spec, to issue a pytest-warning?
4. RonnyPfannschmidt commented on Sep 30, 2015

   

   RonnyPfannschmidt

   on Sep 30, 2015

   MemberAuthor

   More actions

   Yes
5. nicoddemus commented on Sep 30, 2015

   

   nicoddemus

   on Sep 30, 2015

   Member

   More actions

   Fair enough. 😄

   I don't want current users to suddenly start to receive warnings for valid uses of the API though, so I'm thinking of making this an ini option:

   [pytest]
   mock_warnings = yes  # defaults to no

   @RonnyPfannschmidt, @The-Compiler, what do you guys think?

   👍React with 👍1Reacted by Jackson Gilman
6. RonnyPfannschmidt commented on Sep 30, 2015

   

   RonnyPfannschmidt

   on Sep 30, 2015

   MemberAuthor

   More actions

   👍
7. nicoddemus

   added

   enhancement

   on Oct 13, 2018
8. chishaku commented on Dec 21, 2020

   

   chishaku

   on Dec 21, 2020

   More actions

   Thankful I found this issue.

   I'm new to mocking and I was wondering why the test wasn't failing when a mock was called more than once.

   I had

   mocked_function = mocker.patch('app.function')
   do_something()
   mocked_function.called_once()

   The test passed even though called_once isn't even a function.

   After I added autospec=True based on the contents of this issue, I am seeing the errors I'm expecting.

   +1 for the mock_warnings config option.

   Even an update to the docs would be very helpful