ExceptionInfo.for_later() wont add assertion strip text

Using exc_info.exconly(tryshort=True) is meant to remove AssertionError: from the exception message according to (ref)

When 'tryshort' resolves to True, and the exception is an AssertionError, only the actual exception part of the exception representation is returned (so 'AssertionError: ' is removed from the beginning).

However, this is not the case. In addition, the tests do not assert this behaviour:

pytest/testing/code/test_excinfo.py

Lines 332 to 339 in 4489528

    
           def test_excinfo_exconly(): 
        
               excinfo = pytest.raises(ValueError, h) 
        
               assert excinfo.exconly().startswith("ValueError") 
        
               with pytest.raises(ValueError) as excinfo: 
        
                   raise ValueError("hello\nworld") 
        
               msg = excinfo.exconly(tryshort=True) 
        
               assert msg.startswith("ValueError") 
        
               assert msg.endswith("world")

MWE

cat <<-EOF > excinfo_exconly.py
import pytest

def test():
    with pytest.raises(AssertionError) as exc_info:
        raise AssertionError('message')

    assert exc_info.exconly(tryshort=True) == 'message'
EOF
pytest excinfo_exconly.py

Environment

Platform:              linux; (Linux-5.14.21-150500.55.52-default-x86_64-with-glibc2.31)
Python version:        3.10.13 (main, Sep 05 2023, 11:46:10) [GCC])
Python implementation: CPython
Pytest version:		   8.0.2

pytest/src/_pytest/_code/code.py

Line 503 in 4489528

_striptext = ""

seems to fill the strip text incorrectly in this case

the root cause is the for_later helper for making a instance before the exception

we never fill in the strip text for that case

if you create a new exception info object from the value of the one captured the new instance would behave correct

By the way, here is the current workaround I am using in Sphinx (probably imperfect but suitable for my needs):

def parse_excinfo(excinfo: ExceptionInfo[AssertionError]) -> str:
    assert excinfo.type is AssertionError
    assert excinfo.value is not None
    return str(excinfo.value).removeprefix('AssertionError: ')

Fix ExceptionInfo.for_later() not populating _striptext

Derive ExceptionInfo strip text lazily from the exception

Navigation Menu

Repository navigation

`ExceptionInfo.for_later()` wont add assertion strip text #12175

MWE

Environment

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def test_excinfo_exconly():
	excinfo = pytest.raises(ValueError, h)
	assert excinfo.exconly().startswith("ValueError")
	with pytest.raises(ValueError) as excinfo:
	raise ValueError("hello\nworld")
	msg = excinfo.exconly(tryshort=True)
	assert msg.startswith("ValueError")
	assert msg.endswith("world")

ExceptionInfo.for_later() wont add assertion strip text #12175

Description

MWE

Environment

Activity

RonnyPfannschmidt commented on Apr 2, 2024

RonnyPfannschmidt commented on Apr 2, 2024

picnixz commented on Apr 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`ExceptionInfo.for_later()` wont add assertion strip text #12175