Skip to content

config.fromdictargs applies the dictionary after the config object construction instead of  #1743

Open
Open
config.fromdictargs applies the dictionary after the config object construction instead of #1743
Labels
status: criticalgrave problem or usability issue that affects lots of userstype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogtype: bugproblem that needs to be addressed

Description

@RonnyPfannschmidt
RonnyPfannschmidt
opened on Jul 20, 2016

this results in inconsistent/strange behaviour wrt tmpdir, on more than 3 nodes
and inconsistent pluginmanager initialization

Activity

  1. RonnyPfannschmidt
    added
    type: bugproblem that needs to be addressed
    type: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelog
    status: criticalgrave problem or usability issue that affects lots of users
    on Jul 20, 2016

  2. nicoddemus commented on Jul 23, 2016

    @nicoddemus
    nicoddemus
    on Jul 23, 2016
    Member

    I see what you mean @RonnyPfannschmidt. I guess it is a simple fix: get_config receives an optional options dict which is forwarded to the Config constructor.

    Do you plan to work on this? Feels like a good change to go into 3.0.

  3. RonnyPfannschmidt commented on Jul 23, 2016

    @RonnyPfannschmidt
    RonnyPfannschmidt
    on Jul 23, 2016
    MemberAuthor

    i took a initial look and this might turn bigger han expected to end with something thats correct instead of barely passing our tests

  4. nicoddemus commented on Jul 23, 2016

    @nicoddemus
    nicoddemus
    on Jul 23, 2016
    Member

    Hmm OK, bummer. But do you still intend to work on it?

  5. RonnyPfannschmidt commented on Jul 23, 2016

    @RonnyPfannschmidt
    RonnyPfannschmidt
    on Jul 23, 2016
    MemberAuthor

    yes, but im not sure if it can make it into 3.0

    i wonder if its ok to make it into 3.1

  6. nicoddemus commented on Jul 23, 2016

    @nicoddemus
    nicoddemus
    on Jul 23, 2016
    Member

    I think going into 3.1 is fine, no need for 4.0 I mean

  7. RonnyPfannschmidt commented on Jul 23, 2016

    @RonnyPfannschmidt
    RonnyPfannschmidt
    on Jul 23, 2016
    MemberAuthor

    thats also my impression

  8. obestwalter
    added this to detangle the config objecton Jun 17, 2024
  9. obestwalter
    moved this to To do in detangle the config objecton Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: criticalgrave problem or usability issue that affects lots of userstype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogtype: bugproblem that needs to be addressed

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions