Repository navigation
3.7.0: Fixture misses attribute #3747
Description
From #3742 (comment):
Hello! Thank you for this great library! The Mozilla release engineering team relies on it for several projects 😃
I just found a similar regression:
AttributeError: 'async_generator' object has no attribute 'put'This async generator is a regular aiohttp.ClientSession() and is initialized here. This might be an integration issue with the pytest-asyncio plugin.
I rolled pytest back to 3.6.4 and things are back working. You can see both the failure and the workaround in
- Fix fake_session breakage mozilla-releng/beetmoverscript#176
- https://travis-ci.org/mozilla-releng/beetmoverscript/jobs/410250756#L598
Example
I put up a minimal example over here: https://github.com/JohanLorenzo/pytest-fixture-bug-3747
Activity
RonnyPfannschmidt commentedon Jul 31, 2018
@JohanLorenzo the perceived issue can be fixed by reordering the marker and the fixture declaration
due to the introduction of the deprecaationwarning the structure changed a bit and the markers dont pass on
since pytest core doesn't support markers on fixtures to begin with this is a bit of a grey area,
basically this issue is with pytest-asyncio
upon quick skimming i beleive it should have declared an own asyncio_fixture decorator as a starting pointpoint
JohanLorenzo commentedon Jul 31, 2018
Got it. Thanks for the context!
To make sure I get this right, do you mean I should write:
?
RonnyPfannschmidt commentedon Jul 31, 2018
correct - i believe that should work, please report back with the details
JohanLorenzo commentedon Jul 31, 2018
Crap, I get the same error after the marker switch :/
RonnyPfannschmidt commentedon Jul 31, 2018
in that case its a unintended interaction with pytest-asyncio that we aren't aware of, please report against pytest-asyncio as well so we can collaborate on the root cause analysis
JohanLorenzo commentedon Jul 31, 2018
Okay. Looks like pytest-dev/pytest-asyncio#89 was already filed. I commented there.
daniloaf commentedon Jul 31, 2018
I'm having the same issue when using asyncio inside a fixture, but I'm not using the
@pytest.mark.asyncioRefactor direct fixture call warning to avoid incompatibility with pl…
Update pytest to 3.7.1 (#24)
Merge #26
Update pytest to 3.7.1 (#1247)
Update pytest to 3.7.2 (#8)
Scheduled monthly dependency update for October (#389)