Repository navigation
ASYNC102 should allow aclose_forcefully #446
Description
async def _run_handler(stream: StreamT, handler: Handler[StreamT]) -> None:
try:
await handler(stream)
finally:
await trio.aclose_forcefully(stream) # E
this should be allowed, I think. It currently gets this error message:
src/trio/_highlevel_serve_listeners.py:36:9: ASYNC102 await inside try/finally on line 33 must have shielded cancel scope with a timeout.
but this relies on the implementation of aclose_forcefully, which is documented as cancelling immediately.
Activity
A5rocks commentedon Apr 22, 2026
Same for
trio.lowlevel.cancel_shielded_checkpoint, which the name suggests is shielded (and adding a timeout wouldn't make sense, since it's just a single tick).Exempt aclose_forcefully from ASYNC102
Warn on `ExceptionGroup` subclasses without a `.derive()` method (pyt…
A5rocks commentedon Apr 22, 2026
Oops, sorry,
await trio.lowlevel.cancel_shielded_checkpoint()too! Should I open a new issue?Zac-HD commentedon Apr 23, 2026
No need, I'll add that in. (spending a few days vibe-issue-fixing 😁)