Skip to content

type of path parameter in pkgutil.iter_modules #13636

Closed

Description

@srittau

Discussed in python/typing#1946

Originally posted by maarten-vandenberg March 17, 2025
I'm not sure whether this is the right place to ask the following question. If not, I'd be happy to ask it and/or look elsewhere! I could not find an answer searching this forum or typeshed issues, however a related issue might be #6650.

The path parameter in pkgutil.iter_modules is typed as Iterable[str]. However iter_modules also accepts a pathlib.Path, which seems consistent with the call to os.fsdecode in get_importer (accepting PathLike). Am I missing something in how this is typed or is this somehow inconsistent?

Activity

  1. transferred this issue frompython/typingon Mar 17, 2025
  2. srittau commented on Mar 17, 2025

    @srittau
    CollaboratorAuthor

    The annotations were probably never updated. Both iter_modules() and get_importer() seem to accept StrOrBytesPath since at least Python 3.8. PR welcome!

  3. added
    help wantedAn actionable problem of low to medium complexity where a PR would be very welcome
    on Mar 17, 2025
  4. maarten-vandenberg commented on Mar 19, 2025

    @maarten-vandenberg

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedAn actionable problem of low to medium complexity where a PR would be very welcomestubs: false positiveType checkers report false errors

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions