Repository navigation
Limit count calls of setuptAndStart - #16
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
============================================
- Coverage 99.12% 99.09% -0.03%
+ Complexity 155 141 -14
============================================
Files 11 11
Lines 455 442 -13
============================================
- Hits 451 438 -13
Misses 4 4
Continue to review full report at Codecov.
|
* add attribute `$hasChanged` * on each modifications Session informations `$hasChanged` is reset to `true` * `$hasChanged` is put back to false in `setupAndStart`
rancoud
force-pushed
the
fix-optimize-start-session
branch
from
December 9, 2020 01:50
db1a662 to
670320a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A lot of calls in
setupAndStarthappened for nothing, so we need to return early.Changelist
$hasChanged$hasChangedis reset totrue$hasChangedis put back to false insetupAndStart