Repository navigation
Review code - #44
Merged
Merged
Review code#44
Conversation
* add tests files in linter * encapsulate Exception into SessionException * add tests about SessionException * explain codeCoverageIgnore * remove token for codecov * remove option --no-suggest from github action * use multiple php versions (7.4, 8.0) for github action * add functions setLengthSessionID and getLengthSessionID * update README with session options * update comments on Session handler
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=============================================
+ Coverage 99.09% 100.00% +0.90%
- Complexity 141 183 +42
=============================================
Files 11 11
Lines 442 475 +33
=============================================
+ Hits 438 475 +37
+ Misses 4 0 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review code
Changelist