doctor: detect wrong app dependencies #1848

Activity

1. cortinico

   added

   feature request

   command: doctor

   on Feb 27, 2023
2. blakef commented on Mar 20, 2023

   

   blakef

   on Mar 20, 2023

   Contributor

   More actions

   @cortinico checking my understanding of this here, we should be:

   • warning users against linking against a specific version of our dependencies in the packages/ folder (excluding react-native)
   • erroring if the version linked doesn't match minor versions?

   Reference:

   ❯ find . -maxdepth 2 -name 'package.json' | xargs -J % jq '. | {name,version}' %
   {
     "name": "@react-native/babel-plugin-codegen",
     "version": "0.72.3"
   }
   {
     "name": "@react-native/bots",
     "version": "0.0.0"
   }
   {
     "name": "@react-native/codegen",
     "version": "0.72.3"
   }
   {
     "name": "@react-native/eslint-plugin",
     "version": "0.72.0"
   }
   {
     "name": "react-native",
     "version": "1000.0.0"
   }
   {
     "name": "@react-native/normalize-colors",
     "version": "0.72.0"
   }
   {
     "name": "@react-native/hermes-inspector-msggen",
     "version": "0.72.0"
   }
   {
     "name": "@react-native/gradle-plugin",
     "version": "0.72.5"
   }
   {
     "name": "@react-native/eslint-plugin-specs",
     "version": "0.72.2"
   }
   {
     "name": "@react-native/eslint-config",
     "version": "0.72.1"
   }
   {
     "name": "@react-native/js-polyfills",
     "version": "0.72.1"
   }
   {
     "name": "@react-native/virtualized-lists",
     "version": "0.72.2"
   }
   {
     "name": "@react-native/assets-registry",
     "version": "0.72.0"
   }
   {
     "name": "@react-native/tester",
     "version": "0.0.1"
   }
3. cortinico commented on Mar 20, 2023

   

   cortinico

   on Mar 20, 2023

   MemberAuthor

   More actions

   • warning users against linking against a specific version of our dependencies in the packages/ folder (excluding react-native)
   • erroring if the version linked doesn't match minor versions?

   I would start with having both as warnigns. But yes you're correct.

   • If you directly depend on @react-native/codegen, there is probably something wrong with your setup (unless you know what you're doing).
   • If you depend on a version of @react-native/codegen which is misalinged with the react-native minor version, there is definitely somethign wrong going on (things will blow up).
     Still there might be valid scenarios where a user might want to do so, but those are edge cases.

   Starting with both warnigns would be the preffered approach for me
4. github-actions commented on Jun 19, 2023

   

   github-actionsBot

   on Jun 19, 2023

   More actions

   There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
5. github-actions

   added

   stale

   on Jun 19, 2023
6. cortinico

   removed

   stale

   on Jun 19, 2023
7. github-actions commented on Sep 18, 2023

   

   github-actionsBot

   on Sep 18, 2023

   More actions

   There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
8. github-actions

   added

   stale

   on Sep 18, 2023
9. adamTrz

   added

   no-stale-botThis issue cannot be marked as stale by stale botThis issue cannot be marked as stale by stale bot

   and removed

   stale

   on Sep 18, 2023