Adding the package react-native-clean-project to the dependencies makes the config command never exit #567

Activity

1. Pita

   added

   bugSomething isn't workingSomething isn't working

   on Jul 19, 2019
2. thymikee commented on Jul 19, 2019

   

   thymikee

   on Jul 19, 2019

   Member

   More actions

   That's odd. I can reproduce this. Seems like commander refuses to exit cleanly, likely because of some leak (possibly in the mentioned library). In the meantime, here's a workaround (to apply e.g. with patch-package):

   diff --git a/packages/cli/src/cliEntry.js b/packages/cli/src/cliEntry.js
   index b2342de3..d7b2c1d1 100644
   --- a/packages/cli/src/cliEntry.js
   +++ b/packages/cli/src/cliEntry.js
   @@ -114,6 +114,7 @@ const addCommand = (command: CommandT, ctx: ConfigT) => {
          try {
            assertRequiredOptions(options, passedOptions);
            await command.func(argv, ctx, passedOptions);
   +        process.exit(0);
          } catch (error) {
            handleError(error);
          }
   
3. Pita commented on Jul 19, 2019

   

   Pita

   on Jul 19, 2019

   Author

   More actions

   @thymikee Thanks for the quick response!

   Managed to fix it in the library: https://github.com/pmadruga/react-native-clean-project/pull/23/files

   I guess a simple json file for defining these commands would better than running a js file of untrusted code. But I guess thats no simple migration. In the meanwhile process.exit() should mitigate the worst
4. thymikee commented on Jul 19, 2019

   

   thymikee

   on Jul 19, 2019

   Member

   More actions

   Glad you fixed the issue so quickly :)

   guess a simple json file for defining these commands would better than running a js file of untrusted code

   That's a valid concern, and this example shows that the current mechanism can be exploited. Having JS-based config makes it hard to avid. We could require users to explicitly define commands and get rid of auto-discovery, but not sure what's the best path forward here.
5. thymikee

   closed this as completedon Jul 19, 2019