Skip to content

Intermitent test failures in "should register all java commands" #1892

Open

Description

@rgrunber

On the build job, this only fails on Mac but I have been able to reproduce the failures locally as well on Linux.

1) Java Language Extension - Standard
       should register all java commands:
      AssertionError [ERR_ASSERTION]: Some Java commands are not registered properly or a new command is not added to the test.

...
...

      + expected - actual

         "java.action.showSupertypeHierarchy"
         "java.action.showTypeHierarchy"
         "java.apply.workspaceEdit"
         "java.clean.workspace"
      -  "java.edit.organizeImports"
         "java.execute.workspaceCommand"
         "java.ignoreIncompleteClasspath"
         "java.ignoreIncompleteClasspath.help"
         "java.open.clientLog"
--
         "java.open.serverLog"
         "java.project.addToSourcePath"
         "java.project.import"
         "java.project.listSourcePaths"
      -  "java.project.refreshDiagnostics"
         "java.project.removeFromSourcePath"
         "java.project.updateSourceAttachment"
         "java.projectConfiguration.status"
         "java.projectConfiguration.update"

  	at /Users/travis/build/redhat-developer/vscode-java/out/test/standard-mode-suite/extension.test.js:74:20

  	at processTicksAndRejections (internal/process/task_queues.js:97:5)

Activity

  1. rgrunber commented on Apr 20, 2021

    @rgrunber
    MemberAuthor

    vscode.commands.getCommands(true).then((commands) => {...}) sometimes returns N command and occasionally starts returning N+2 (the extra 2 commands from above). This is starting to look like some kind of timing issue.

    I'm still not sure why those 2 commands are taking longer to return when there are others defined in the jdt.ls.core extension point (plugin.xml) that make their way into commands list every time.

    We did skip them in the release build, so at least we're consistent now until we can determine what the issue is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions