Repository navigation
lombok.config ignored in 1.14.0 #2887
Description
After updating the extension to 1.14.0, my lombok.config file is being ignored, specifically the lombok.log.fieldName=LOG setting.
Environment
- Operating System: Windows
- JDK version: 14
- Visual Studio Code version: 1.74.3
- Java extension version: 1.14.0
Steps To Reproduce
- Extract attached project
- Running
mvn clean packagefrom the commandline succeeds - Loading the project into vscode with the 1.14.0 extension shows the error
Sample reproducer:
vscode-java-issue.zip
Issue example:
Current Result
vscode shows that LOG cannot be resolved to a variable, and log is not used.
Expected Result
lombok.config changes log to LOG so this error/warning combo should not be shown.
Additional Information
I did confirm that manually reverting back to 1.13.0 makes the issue go away.
Activity
FlipWarthog commentedon Jan 18, 2023
Lombok Configuration reference: https://projectlombok.org/features/configuration
schophil commentedon Jan 18, 2023
I have got the same issue with the @CustomLog annotation.
vdkhvb commentedon Jan 18, 2023
Can confirm, I got these issues as well (CustomLog annotation fails & renaming of log field is not applied). It all boils down to not processing the lombok.config file. Simply downgrading the plugin fixes the issue, whilst playing with the flag for disabling lombok support or picking the lombok jar doesn't help.
snjeza commentedon Jan 18, 2023
This is an upstream lombok issue related to
Lombok can't load the ResourcePlugin class at https://github.com/projectlombok/lombok/blob/master/src/core/lombok/eclipse/EclipseAST.java#L191
@FlipWarthog Could you try Lombok 1.18.26?
FlipWarthog commentedon Jan 19, 2023
@snjeza Trying the jar provided and setting the
javaagentparam results in the same issue after updating to 1.14.0 of the extension. Not sure what 1.18.26 of Lombok is since it looks like the latest snapshot is only 1.18.25 (Note: even trying that Edge release from Lombok I'm still seeing the issue).And using any of these versions of Lombok with the 1.13.0 version of the extension shows it working properly, so I can't wrap my head around how it could be upstream?
snjeza commentedon Jan 19, 2023
@FlipWarthog https://github.com/snjeza/vscode-test/raw/master/lombok-1.18.26.jar is a patched lombok jar.
Could you try the following properties:
Eclipse JDT has been changed. The Eclipse ECJ plugin doesn't include the resources and runtime plugin - https://www.eclipse.org/eclipse/news/4.27/jdt.php#ecj-separated-from-core
Java LS >= 0.14.0 uses Eclipse 4.27.
It causes this issue with lombok. lombok-1.18.26 should fix it.
FlipWarthog commentedon Jan 19, 2023
@snjeza Ahh, that worked and thank you for the clarification! Explicitly disabling loading from the project classpath was key, in addition to setting the
javaagentto point to the patched version. Thanks, again.snjeza commentedon Jan 19, 2023
@FlipWarthog I have created projectlombok/lombok#3332
rgrunber commentedon Apr 13, 2023
Re-opening as we've reverted the change that fixed this due to potentially more serious issues with the lombok edge release. Hopefully we can fix these in subsequent release.
Internal compiler error: java.lang.NoClassDefFoundError
snjeza commentedon Apr 15, 2023
This issue hasn't been fixed properly.
Steps to reproduce:
$ cd vscode-java-issue
$ code .
You will get
LOG cannot be resolvedA workaround
Developer: Reload Windowjcolladosp commentedon Apr 17, 2023
any update in this issue?
Eskibear commentedon Apr 17, 2023
yes, I think. A fix in upstream has been released, see projectlombok/lombok#3406 (comment)
Next step would be adopting #3031 again and give it a try on the coming pre-release. @jcolladosp you can keep an eye on it.