Skip to content

Calibrated parameters are not tied to the inputs they were fit on #23

Open

Description

@rishigraham

model_load picks the parameter file and each input file separately, taking the newest date of each (R/data_loadmodel.R:63, R/data_loadmodel.R:84, R/data_loadmodel.R:97). Nothing records which inputs a calibration was fit on, so a parameter set can run with inputs it was never calibrated against.

  • ND
    • model_load selects ND_ModelInputs_12-14-21.rds
    • the stored ND_Optim_all_15_0708.rds optimum was fit on ND_ModelInputs_11-12-21.rds
    • that optimum's -log posterior is 1255.69 with the inputs it was fit on and 1573.26 with the inputs model_load selects
  • Any location
    • adding a newer ModelInputs, CalibDat or other input file to a configuration changes what an existing Param file runs with, without recalibrating
  • Wrapper
    • calibrate mode writes {LOC}_Param_*.rds without recording the inputs behind it (resilientsims/wrapper.R:196)
    • package and scenario modes run the configured Param file with whatever inputs are newest (resilientsims/wrapper.R:149-153)

Fix on branch rsims-wrapper.

Line numbers refer to branch rsims-wrapper at 5e4d6bc2, as of 2026-11-05.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions