Repository navigation
Bug: type issue in ts@4.8+ with esm #1348
Description
A lot of plugins are exporting esm version
In a recent change in ts4.8, this leaves to type failue. as typescript@4.8+ will assume users are importing a commonjs module.
Here is a example:
TS will report issues with:
import commonjs from "@rollup/plugin-commonjs";
commonjs()Saying the expression is not callable.
That's because a cjs module will have it's module.exports on default key, so:
import commonjs from "@rollup/plugin-commonjs";
commonjs.default()is fine to typescript, but it's not acually working (because we do have esm modules using export default)
This happens under
- esm package (with
type: modulein pacakge.json) and of coursetarget: ESxxxin ts.config.json - together with
moduleResolution: NodeNextis in ts.config.json
Activity
Mister-Hope commentedon Nov 19, 2022
Mister-Hope commentedon Nov 19, 2022
I belived this issue is releated to microsoft/TypeScript#50690
Adding
type: modulein package.json can solve the problem at my use case, but I am not pretty sure if it will break other use cases.shellscape commentedon Nov 19, 2022
Thanks for opening an issue. Citing the issue template:
We cannot make this any clearer. Please add a reproduction and we'll be happy to triage further.