Recommend check / test version numbering #41

Activity

1. jarrodmillman commented on Sep 11, 2023

   

   jarrodmillman

   on Sep 11, 2023

   MemberAuthor

   More actions

   Just so folks don't need to follow the link above:

   >>> from packaging import version
   >>> version.parse("3.8.0rc1") < version.parse("3.8.0.dev1951+g5f785e3e19")
   False
   >>> version.parse("3.8.0rc1") < version.parse("3.8.0rc1.dev1951+g5f785e3e19")
   False
   >>> version.parse("3.8.0rc1") < version.parse("3.8.0rc1.dev0")
   False
   >>> version.parse("3.8.0rc1") < version.parse("3.8.0rc2.dev0")
   True
   >>> version.parse("3.8.0rc1") < version.parse("3.8.0rc2.dev1951+g5f785e3e19")
   True
   

   So after releasing 3.8.0rc1 the basic version number should be updated to 3.8.0rc2.dev0 or 3.8.0rc2.dev.
2. bsipocz commented on Sep 11, 2023

   

   bsipocz

   on Sep 11, 2023

   Member

   More actions

   Thanks for the heads up, the first one is surprising, the rest is what I was expecting.

   As for testing, would you suggest to test whether it's possible to install the latest uploaded nightly? E.g. with astropy I ended up in a situation where the pip install worked, but it picked up an older nightly which masked over an issue with the wheels (and a newly added dependency) perfectly.

   👍React with 👍1Reacted by Jarrod Millman
3. jarrodmillman commented on Sep 11, 2023

   

   jarrodmillman

   on Sep 11, 2023

   MemberAuthor

   More actions

   As for testing, would you suggest to test whether it's possible to install the latest uploaded nightly?

   Yes, exactly. Maybe a cron job once a week or so to test whether the recommended pip command is able to install the most recent nightly wheels.
4. martinfleis commented on Sep 11, 2023

   

   martinfleis

   on Sep 11, 2023

   Member

   More actions

   And what would be the action if the job fails? Getting back to a project, suggesting they need to change the version of the dev branch?

   👍React with 👍1Reacted by Jarrod Millman
5. bsipocz commented on Sep 11, 2023

   

   bsipocz

   on Sep 11, 2023

   Member

   More actions

   And what would be the action if the job fails? Getting back to a project, suggesting they need to change the version of the dev branch?

   Yes, I suppose an issue being auto-opened here, and then one of us following up with the project. This of course assumes that the problem is scaling well, e.g. we won't host gazillions of wheels as a "conda-forge for wheels", but keep it to the core ones.
6. matthewfeickert commented on Feb 8, 2024

   

   matthewfeickert

   on Feb 8, 2024

   Member

   More actions

   I didn't follow this closeley in 2023 (sorry), but given @ksunden's comment matplotlib/matplotlib#26736 (comment) was this actually a systematic problem that a check would have help avoid? Or was this simply a time delay issue for information to get propaged to matplotlib's main branch so it could end up in the matplotlib nightly wheels?