[bug] script sync issue

[gaveitatry2]

I had installed the 'Better Google' userscript from here:
https://greasyfork.org/en/scripts/395257-better-google

ScriptCat suddenly had a popup message that I could not read because it was in Chinese. I just recognized the words 'Better Google'. Also, I don't like popup messages so there should be a way to disable them.

I then went to look at my Installed Scripts, and 'Better Google' had been removed.

1.) ScriptCat should not remove userscripts without my permission.

2.) ScriptCat should have a Trash folder for deleted userscripts in case the user made a mistake and wants to undelete something.

Chrome 142.0.7444.163. ScriptCat 1.1.2.

/////////////////////////////////////////////////////////

我之前从这里安装了“Better Google”用户脚本：

https://greasyfork.org/en/scripts/395257-better-google

ScriptCat 突然弹出一个消息框，但我看不懂，因为它是中文的。我只认出了“Better Google”这几个字。另外，我不喜欢弹出消息框，所以应该有办法禁用它们。

然后我查看了已安装的脚本，发现“Better Google”脚本已经被删除了。

1）ScriptCat 不应该在未经我许可的情况下删除用户脚本。

2）ScriptCat 应该有一个“回收站”文件夹来存放已删除的用户脚本，以防用户误删后想要恢复。

Chrome 142.0.7444.163. ScriptCat 1.1.2.

[cyfung1031]

@gaveitatry2 Can you reproduce the Number 1? There is no auto-delete feature in ScriptCat. If you can reproduce it, please provide the reproduction steps.

For Number 2, this feature is not yet implemented.

[CodFrm]

Perhaps it was a misoperation. On which page did the pop-up appear? All parts of ScriptCat are translated and should not display Chinese unless your language setting is Chinese.

[gaveitatry2]

@CodFrm - I had two browser windows open, one on each screen. On one screen, I was watching Twitch. I forgot what I was doing on the second screen. I think that I was watching another video in fullscreen on my second screen. I saw a popup widow appear in the bottom right corner of the fullscreen video on the second screen. It was in Chinese, but I recognized the English words "Better Google". I closed out of the video and and opened up the ScriptCat settings and looked at my installed scripts. "Better Google" had been removed even though I had installed it 30-60 minutes ago. I don't know how to duplicate this issue. Not everything has been translated to English. For example, if I try to install the 'vaft' userscript from the TwitchAdSolutions GitHub, a ScriptCat page will load in my browser telling me that it can't install the userscript and everything on the page will be in Chinese. I am sorry that i have not reported this problem yet. I will create an issue on it later. I suspect that the problem was that ScriptCat is buggy when it comes to installing userscripts, so it installed it but it was not a stable installation. So it seemed to be working but then ScriptCat said "this was a buggy installation, so I want to uninstall it." and so it did. Anyway, talking about it does not help. What we really need is a 'Trash' folder, so if anything gets deleted, there is a second chance to restore it. It would be horrible if someone accidentally deleted something, or made the wrong decision and changed their mind, or if ScriptCat acts buggy and deletes something. We need a second chance to recover stuff.

[CodFrm]

@gaveitatry2 Did you use the sync or subscription feature?

if I try to install the 'vaft' userscript from the TwitchAdSolutions GitHub, a ScriptCat page will load in my browser telling me that it can't install the userscript and everything on the page will be in Chinese.

Waiting for your report, I will check it.

What we really need is a 'Trash' folder, so if anything gets deleted, there is a second chance to restore it.

As @cyfung1031 mentioned, this is already planned in #668 and might be implemented in the next two versions.

[gaveitatry2]

@CodFrm - Yes, I set up sync around two days ago. I am not sure if I did it correctly though. Everything is confusing to me. I was trying to create automatic backups to Google Drive. Did I do it right?

[CodFrm]

@CodFrm - Yes, I set up sync around two days ago. I am not sure if I did it correctly though. Everything is confusing to me. I was trying to create automatic backups to Google Drive. Did I do it right?

Your sync configuration is correct and successfully enabled. This issue was likely caused by the "sync delete" feature. If you deleted "Better Google" on another device, the sync process would notify you of the script deletion (the Chinese notification text may be due to an unhandled translation issue that needs checking).

[gaveitatry2]

@CodFrm - Yes, that would make sense if I deleted "Better Google" on another device. But I did not. I only have one device and I was occupied with watching videos. That is what concerns me.

EDIT: Since then, I re-installed "Better Google" and it is still there.

EDIT: But if something gets deleted, I wish that there was a log of what was deleted and when. I don't want userscripts getting deleted when I go to the restroom and not know that it was deleted.

[CodFrm]

@CodFrm - Yes, that would make sense if I deleted "Better Google" on another device. But I did not. I only have one device and I was occupied with watching videos. That is what concerns me.

EDIT: Since then, I re-installed "Better Google" and it is still there.

EDIT: But if something gets deleted, I wish that there was a log of what was deleted and when. I don't want userscripts getting deleted when I go to the restroom and not know that it was deleted.

Understood. It was likely that a deletion operation for "Better Google" was recorded previously, and this "deleted" status wasn't properly reset after you reinstalled it. This should be a bug, and I will look into it.

You can check the related logs via the log feature (although it might not be very user-friendly for non-technical users).

[gaveitatry2]

@CodFrm - That makes sense. I did delete and install "Better Google" several times in quick succession while testing something. I could uncheck 'Sync Delete' to be safe. I am not sure what I should do. It is unlikely that I would delete my own userscript that I created. But what if I deleted it and then created a new one with the same name? Then Google Drive might have some record of me deleting the userscript and then tell ScriptCat to delete it again, and then my second userscript will get deleted although I wanted to keep it. But if I turn 'Sync Delete' off, that means I would have a lot of userscripts saved that I don't want. Maybe the best approach for me is to turn 'Sync Delete' off and then backup manually from time to time. My manual backup will be the clean backup. The online backup will be the last resort?

[CodFrm]

@gaveitatry2

This is indeed a bug, and I will investigate and fix it. The "Sync Delete" feature is designed for use with multiple devices. You can safely disable it without affecting your setup.

Sync and Backup are two different features:

• Sync continuously updates data to the cloud drive, allowing other devices to pull and synchronize, keeping all devices consistent (although script data is not currently synced).

• Backup only saves a snapshot of the data at the moment you manually trigger it (and this includes script data).

[cyfung1031]

This is indeed a bug, and I will investigate and fix it. The "Sync Delete" feature is designed for use with multiple devices. You can safely disable it without affecting your setup.

@CodFrm For being safe, it should be disabled by default. And show warning to confirm action if users check it.

[gaveitatry2]

It is disabled by default, but a warning would be useful.