You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Serverless Framework v3: integrating with the new design #279
@medikoo@mnapoli Started a PR to address this - NodeJS is not my strong suite so I'm happy to receive critical feedback. Are there any recommended testing practices to ensure compatibility with v3?
@colemanja91 there are not many internal differences between v2 and v3, so v3 doesn't change much in that area.
In general, we recommend using runServerless util to set up tests that involve Framework (we use it in Framework internal tests and plugins)
I saw that you've prepared a PR with new logs. In Framework, we do not pursue any tests that confirm whether the given log is written. We only confirm on result state of the operation, and eventually the substantial command output (one written with writeText).
So when logs refactor is concerned, most that needs to be ensured is that currently setup tests pass, I wouldn't expect new tests to confirm on new logs configuration.
Activity
medikoo commentedon Nov 23, 2021
@mnapoli it's a package we maintain (note the organization :)
medikoo commentedon Nov 23, 2021
Still, we welcome any help on it from outside. So if there's anyone that can help us, integrating with a new design that's highly appreciated!
mnapoli commentedon Nov 23, 2021
🤦 I just opened this issue after opening one on the Azure plugin, I didn't even notice the org ^^
Well, at least the info is out there for those that may want to contribute :D
colemanja91 commentedon Jan 8, 2022
@medikoo @mnapoli Started a PR to address this - NodeJS is not my strong suite so I'm happy to receive critical feedback. Are there any recommended testing practices to ensure compatibility with v3?
medikoo commentedon Jan 10, 2022
@colemanja91 there are not many internal differences between v2 and v3, so v3 doesn't change much in that area.
In general, we recommend using
runServerlessutil to set up tests that involve Framework (we use it in Framework internal tests and plugins)I saw that you've prepared a PR with new logs. In Framework, we do not pursue any tests that confirm whether the given log is written. We only confirm on result state of the operation, and eventually the substantial command output (one written with
writeText).So when logs refactor is concerned, most that needs to be ensured is that currently setup tests pass, I wouldn't expect new tests to confirm on new logs configuration.