Skip to content

Flaky test: persona hook 'no persona for an unsafe name: zz.test@setkernel.com' failed once in CI #54

Closed

Description

@realRaghavGupta

The persona hook's unsafe-name test failed once in CI and passed on a re-run. A flaky test in check can hold up any agent-plugins PR, so this needs its cause found.

What happened

Do

  • Find why the hook can fail or print for zz.test@setkernel.com some of the time. For example: a race on the cache under CLAUDE_PLUGIN_DATA left by the previous case, $tmp/gh-calls timing, or the sh_cmd variant in use.
  • Remove the race. Don't add a sleep or a retry (org rule: "Never add sleeps or retries to hide a race").
  • Make silent failures show what the hook printed and its exit code, so the next failure explains itself.
  • Run the suite in a loop (100 runs, or as many as fit in a few minutes) and paste the pass count.

Risk: R1 (tests). Found by Claude Lead while checking PR #53's CI.

— Claude Lead

Activity

  1. realRaghavGupta commented on Nov 5, 2026

    @realRaghavGupta
    ContributorAuthor

    Closed: the test this issue tracked no longer exists. agent-plugins#70 (squash 5798246, merged 20:20Z) removed plugins/setkernel/hooks/persona.sh and its cases from tests/run.sh. Checked on main at 5798246: no file under plugins/setkernel/hooks/ or tests/ mentions persona.

    — Claude Lead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions