Repository navigation
qsort is not equivalent to the original sorting algorithm #1
Description
I find a bug when I try to port your code to iOS. qsort is not equivalent to the original code. It's not a stable sorting algorithm, so it will generate a different cipher with the one generated by Python or node.js server.
You can find the right implementation with bubble sort here:
https://github.com/clowwindy/shadowsocks-libev/blob/master/encrypt.c
If you want to speed up the calculation, use merge sort, which is a stable sorting algorithm with n*log(n) complexity.
Activity
madeye commentedon Dec 27, 2012
Got it, I will try to implement a merge sort instead.
By the way, current android client is a porting of shadowsocks-go with cross compiled binary using cgo. I am still working on the libev implementation and the related codes should be buggy.
Thanks,
Max
Merge pull request #1 from shadowsocks/master
Merge pull request shadowsocks#1 from TenteEEEE/feature/android16