update engine.io version to 1.5.4 #2245

Activity

1. nicofff commented on Sep 14, 2015

   

   nicofff

   on Sep 14, 2015

   More actions

   +1
2. torvalamo commented on Sep 14, 2015

   

   torvalamo

   on Sep 14, 2015

   More actions

   It is updated on github, so if you do

   npm install git+https://github.com/socketio/socket.io
   

   you've got it.

   However there is one bug, which is that engine.io complains that module base64id isn't found. So you need to

   npm install base64id
   

   separately, and you're good to go. At least I haven't seen anything bad yet apart from that.
3. vsharmaGit commented on Sep 15, 2015

   

   vsharmaGit

   on Sep 15, 2015

   Author

   More actions

   unfortunately, we don't have GIT installed in our build environment as well this doesn't solve our issue since socket.io is a dependency for browser-sync and karma.
4. maxscott commented on Sep 15, 2015

   

   maxscott

   on Sep 15, 2015

   More actions

   +1 if you have a direct dependency on socket.io this is enough, but for everyone else, it means forking your real dependenc(ies) and bumping the socket.io reference... I'd love to see a patch release resolving this.
5. justerhan commented on Sep 17, 2015

   

   justerhan

   on Sep 17, 2015

   More actions

   @torvalamo 's suggestion didn't work for me :( . Very annoying, especially regarding @maxwerr 's point. I used npm's built-in shrinkwrap command (https://docs.npmjs.com/cli/shrinkwrap) to get this working in node v4.0.0. The shrinkwrap command allows you to bump the version number in your dependant packages without having to fork them. You can run the failed npm install command and still generate the proper npm-shrinkwrap.json file then bump the engine.io version. Pretty handy in these kind of situations.
6. maxscott commented on Sep 18, 2015

   

   maxscott

   on Sep 18, 2015

   More actions

   @BountyX that's really smart. great workaround until this passes tests and gets released..
7. jldec commented on Sep 21, 2015

   

   jldec

   on Sep 21, 2015

   More actions

   appears to be fixed in socket.io v1.3.7
8. mikermcneil commented on Sep 22, 2015

   

   mikermcneil

   on Sep 22, 2015

   More actions

   @jldec 👍 @rauchg published 1.3.7 yesterday which depends on engine@1.5.4

   @vsharmaGit I imagine this can be closed :)
9. vsharmaGit commented on Sep 23, 2015

   

   vsharmaGit

   on Sep 23, 2015

   Author

   More actions

   Awesome...thanks for the update
10. vsharmaGit

    closed this as completedon Sep 23, 2015