You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Link click handling breaks the <Router> isolation/context principle #298
I'm making the assumption here that this package supports multiple routers running at the same time as it does use context for isolation instead of some kind of global store. Described bug is not an issue if my assumption is wrong.
Router component provides context which isolates and enforces the scope of router functionality.
For example useLocation under <Router> returns the location for that particular router.
Link click handling (A component) breaks that principle and functionality because link click event handler is added to document and if you have multiple routers (with default integration or custom), only one integration setter will be always called.
I propose to handle it in some sort of scoped way, for example: <Router scopeEl={htmlElementRef} source={integration}> and
Go to Home (/) if not already there and open console
Click on any of the "Post X (modal)" links
Clear console log
Click on any of the "Post X (modal)" links in modal (links under router 2)
You can see in logs [router 1] set global loc: that even though this link is rendered under second <Router>, it will still invoke the setter for first <Router> integration.
Expected behavior
Link behaviour respects the context.
Link rendered under <Router1 source={integration1}> should invoke the integration1 setter.
Link rendered under <Router2 source={integration2}> should invoke the integration2 setter.
Activity
adjourn commentedon Sep 6, 2023
Tried out my first suggestion locally, works wonderfully.
Changes in router (
node_modules dist/index.js):What do you think?
ryansolid commentedon Dec 7, 2023
We should look at this.. Either that or have the router create an element itself.