useSearchParams suggestion

It would be very needed that setSearchParams from solid-start works like setting state, meaning it holds previous value and overwrites existing state when omitting prev. That way, it both works when you want to overwrite existing or append.

setSearchParams({ hello: "world" }) //overwrites existing
setSearchParams(prev => ({...prev, hello: "world" })) //appends

Undefined for delete ?

setSearchParams(prev => ({...prev, hello: undefined })) // delete

i think proxy is needed for reactivity
the current useSearchParams function could be updated
didn t try tbh

https://github.com/solidjs/solid-router/blob/HEAD/src/routing.ts#L100-L115

export const useSearchParams = <T extends Params>(): [
  T,
  (newParams: SetParams | ((current: Readonly<T>) => SetParams), options?: Partial<NavigateOptions>) => void
] => {
  const location = useLocation();
  const navigate = useNavigate();
  const setSearchParams = (params: SetParams | ((params: Readonly<T>) => SetParams), options?: Partial<NavigateOptions>) => {
    const searchString = typeof params === "function"
      ? untrack(() => mergeSearchString("", params(location.query as T)))
      : untrack(() => mergeSearchString(location.search, params));
    navigate(location.pathname + searchString + location.hash, {
      scroll: false,
      resolve: false,
      ...options
    });
  };
  return [location.query as T, setSearchParams];
};

you might be able to use produce https://www.solidjs.com/docs/latest/api#produce
again, i didn t try

: untrack(() => mergeSearchString("", params));

would be a breaking change

I don't really like the delete keyword in general so this doesn't bother me but that's a personal preference and I'm not a core member ;)

I think Ryan spoke about this pattern for store in one of his streams. I'll add the link if I find it.

Hey @rattleSSnake
I share the logic here but I don't think the breaking change is a good idea.
Noneless I'd be happy to make the change and refactor mergeSearchString if the reviewer asks me to do so.

This will reset search params

setSearchParams(prev => ({ }));

Just to add in to this - I'm looking to support Browsers before Proxy support is added. I'd prefer for it also to be a plain Object. If there is any way to do this without proxy (maybe defining which search or query params one was looking for). I'll be diving into Router code this week probably forking it to remove that for now as I don't need reactive params.

Just to add in to this - I'm looking to support Browsers before Proxy support is added. I'd prefer for it also to be a plain Object. If there is any way to do this without proxy (maybe defining which search or query params one was looking for). I'll be diving into Router code this week probably forking it to remove that for now as I don't need reactive params.

It's tricky from a general sense because params can change shape, ie be added removed. My gut is I can't just get rid of the proxy here.

I'm looking at this now. I think for params you could process all the routes and look for all the defined params and create an object with get / set for each of the possible params from the routes.

For Query params you'd need to be told all the possible query params. I think it's doable to avoid the proxy.

Navigation Menu

Repository navigation

`useSearchParams` suggestion #328

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

useSearchParams suggestion #328

Description

Activity

xrtis commented on May 28, 2023

xrtis commented on May 28, 2023

xrtis commented on May 28, 2023

xrtis commented on May 28, 2023

xrtis commented on May 31, 2023

xrtis commented on May 31, 2023

chiefcll commented on Sep 8, 2024

ryansolid commented on Sep 9, 2024

chiefcll commented on Sep 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`useSearchParams` suggestion #328