handleAnchor and blob links #382

Activity

1. titoBouzout commented on Feb 23, 2024

   

   titoBouzout

   on Feb 23, 2024

   Author

   More actions

   It seems like a.href doesn't have a complete URI when a link is in a blob. Maybe you can check if a.hostname is empty and somehow construct the full URI.

   solid-router/src/data/events.ts

   Line 38 in 5ac8ff5

   const href = svg ? a.href.baseVal : a.href;

   
   I wanted to send a pull request, but all the basePath stuff is mysterious enough. It costs nothing to add 1 line comment on a logic condition on the lines of "this check for X because Y and Z happens"
2. ryansolid commented on Feb 27, 2024

   

   ryansolid

   on Feb 27, 2024

   Member

   More actions

   Honestly I don't know. Which is sort of the challenge with the router. Most the core logic was authored by the previous maintainer, and then was augmented by the community. I've been looking for people interested in helping maintaining the router because I haven't had the chance to look that deeply in how it works.

   👍React with 👍1Reacted by Tito
3. ryansolid

   added

   enhancementNew feature or requestNew feature or request

   on Jul 15, 2026
4. aashish00021

   added a commit that references this issue on Jul 31, 2026

   fix: skip non-http(s) links in anchor click handler

   ...

   This issue will close once commit aa738bc is merged into the 'main' branch.

   aa738bc
5. ryansolid commented on Oct 14, 2026

   

   ryansolid

   on Oct 14, 2026 – with Claude

   Member

   More actions

   Fixed on the 2.0 line: anchor click handling no longer intercepts links with a non-http(s) scheme (blob:, mailto:, tel:, data:, …), so blob: links are left to the browser. It's in the @solidjs/router@next prereleases (currently 2.0.0-next.39). It merged into the next branch, so this issue didn't close automatically.

   — Claude via Claude Code

   ---

   Generated by Claude Code
6. ryansolid

   closed this as completedon Oct 14, 2026
7. ryansolid

   reopened this on Oct 14, 2026
8. ryansolid commented on Oct 14, 2026

   

   ryansolid

   on Oct 14, 2026 – with Claude

   Member

   More actions

   Reopening: the fix is on the 2.0 (next) line, but this is a non-breaking bug fix that should also land on 1.x. #581 targets main for that.

   — Claude via Claude Code

   ---

   Generated by Claude Code
9. ryansolid

   added

   1.x

   on Oct 14, 2026