createSource: source is not reactive when use props #659

import { createSignal, Suspense, createResource, createEffect } from 'solid-js'
import { render } from 'solid-js/web'

const fetchUpperName = async (name: string) => {
  console.log('fetching', name)
  await new Promise(r => setTimeout(r, 1000))
  return name.toUpperCase()
}

function UpperName(props: { name: string }) {
  const [upperName] = createResource(props.name, fetchUpperName)
  createEffect(() => {
    console.log('name', props.name, upperName())
  })
  return <h1>Hello, {props.name} = {upperName}</h1>
}

export default function App() {
  const [name, setName] = createSignal('noname')
  const updateName = (name: string) => () => setName(name)

  return (
    <>
      <button onClick={updateName('Neo')}>Neo</button>
      <button onClick={updateName('Chris')}>Chris</button>
      <p>Name: {name()}</p>
      <Suspense fallback={<p>Loading</p>}>
        <UpperName name={name()} />
      </Suspense>
    </>
  )
}

render(() => <App />, document.getElementById("app"))