Skip to content

moving to experimental - #2172

Merged
josehelps merged 1 commit into
developfrom
moving_tcp_command_and_scripting_interpreter_outbound_ldap_traffic
Apr 14, 2022
Merged

moving to experimental#2172
josehelps merged 1 commit into
developfrom
moving_tcp_command_and_scripting_interpreter_outbound_ldap_traffic

Conversation

@josehelps

@josehelps josehelps commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

PR Template for new Detections

Moving detection to experimental

For Authors:

For Reviewers:

  • Verify CI/CD jobs have passed without errors.
  • Validate SPL logic.
  • Validate tags, description, and how to implement.
  • Validate name matches <platform>_<mitre att&ck technique>_<short description>
  • Verify references match analytic.
  • Is there an Atomic Test?

@auto-assign
auto-assign Bot requested a review from patel-bhavin April 14, 2022 20:38
ljstella
ljstella approved these changes Apr 14, 2022
View reviewed changes

@ljstella ljstella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josehelps
josehelps enabled auto-merge April 14, 2022 20:39
@josehelps
josehelps merged commit e00c2ed into develop Apr 14, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the moving_tcp_command_and_scripting_interpreter_outbound_ldap_traffic branch April 14, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljstella ljstella ljstella approved these changes
@patel-bhavin patel-bhavin Awaiting requested review from patel-bhavin patel-bhavin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josehelps @ljstella