Repository navigation
Detection fixes - #2260
Merged
Merged
Detection fixes#2260
Conversation
line. It does not appear to exist in the raw data and is not pulled into any field(s). However, there is a field called userName which, presumably, represents the same data.
that was created when custom_index support did not yet exist.
since it does not exist and the field userName does exist. And it is likely to have captured the same data.
file that was failing because it did not have one.
josehelps
approved these changes
Jun 22, 2022
josehelps
enabled auto-merge
June 22, 2022 17:17
josehelps
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some detections that were failing in CI/CD because they didn't include custom_index AND fixes some detections that were failing (I think) because they included a stats field (user) that does not exist in the raw data. Also fixes a field which was renamed in a sysmon update.
Double-check that the meaning of the logic in the detection did not change.