Repository navigation
CRL_1700 ES Macros - #278
Conversation
…s to use this new macro, removing ES dependecy
trogdorsey
left a comment
There was a problem hiding this comment.
baselines/discover_dns_records was not updated correctly
trogdorsey
left a comment
There was a problem hiding this comment.
detections/dns_evilginx_subdomains.yml needs to be fixed
trogdorsey
left a comment
There was a problem hiding this comment.
detections/dns_record_changed.yml needs to be updated
trogdorsey
left a comment
There was a problem hiding this comment.
detections/dyn_dns_web_traffic.yml
trogdorsey
left a comment
There was a problem hiding this comment.
detections/no_win_updates_in_timeframe.yml
trogdorsey
left a comment
There was a problem hiding this comment.
investigations/first_occurrence_mac_address.yml
trogdorsey
left a comment
There was a problem hiding this comment.
detections/ec2_instance_started_with_previously_unseen_ami.yml
trogdorsey
left a comment
There was a problem hiding this comment.
detections/large_icmp_outbound.yml
trogdorsey
left a comment
There was a problem hiding this comment.
detections/cloud_compute_instance_created_by_previously_unseen_user.yml
trogdorsey
left a comment
There was a problem hiding this comment.
detections/new_aws_console_login_by_user.yml
|
updated as per dorsey's feedback, fixed some other files too. updated searches for naming consistency as well, while i was at it |
|
@trogdorsey : Can you perhaps review this? want to make sure i didnt miss anything |
|
@patel-bhavin @trogdorsey : Should the macro security_content_ctime not be independent from ctime (not use ctime)? Otherwise, ES needs to be installed to run our searches. In my opinion we need to put the content of ctime in the macro and not a reference to ctime. |
|
@patel-bhavin I found an issue with the comment macro (which is used for empty pre and post filter). If you want to run the search in any app besides search, the searches will fail because the comment macro is shared only inside the search app. We should ship with a config which makes the comment macro global accessible. |
|
@P4T12ICK : removed the comment macro all together after chatting with @d1vious |
security_content_ctimereplacing the ctime macro across all contentsecurity_content_summariesonlyreplacing the summariesonly macro across all content