Repository navigation
Unit-Testing using contentctl - #3028
Merged
Merged
Conversation
patel-bhavin
commented
Jul 8, 2024
pyth0n1c
previously approved these changes
Jul 9, 2024
pyth0n1c
left a comment
pyth0n1c
left a comment
Collaborator
There was a problem hiding this comment.
I believe this looks good. After it is merged, we should do some stress-testing where we open a PR from an external (non splunk/security_content member) repo to ensure that the mode:changes functionality works from external forks as well.
| @@ -23,29 +21,20 @@ jobs: | |||
| run: | | |||
Collaborator
There was a problem hiding this comment.
I don't think this workflow needs jq (anymore) can it be removed entirely?
|
|
||
| - name: Install System Packages and contentctl | ||
| run: | | ||
| sudo apt update -qq |
Collaborator
There was a problem hiding this comment.
Now that we are doing the processing with python i think we can remove jq?
Contributor
Author
|
This workflow was also tested on PR from Dean Luxton (Splunker) and it seemed to have worked correctly! You can check the run here : |
pyth0n1c
approved these changes
Jul 10, 2024
pyth0n1c
left a comment
pyth0n1c
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed workflow and results. Looks great! Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables Unit-testing in Github Actions CI using contentctl.
Additionally added a script to pretty print the pass/failures of detections from summary.yml