Repository navigation
Valleyrat fixes! - #3137
Merged
Merged
Valleyrat fixes!#3137
Conversation
patel-bhavin
requested review from
pyth0n1c and
tccontre
and removed request for
ljstella
September 24, 2024 20:37
pyth0n1c
approved these changes
Sep 25, 2024
pyth0n1c
left a comment
pyth0n1c
left a comment
Collaborator
There was a problem hiding this comment.
These fixes are based on internal feedback and discussion with the developer. They look good to me!
Contributor
Author
|
known failures in app inspect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates from eric's comments!