Repository navigation
Remove 151 Deprecated detections, stories, baselines, investigations - Github - #3366
Merged
Merged
Conversation
patel-bhavin
changed the title
patel-bhavin
changed the title
replacement_content if there is no content defined
Proposed format update for deprecation file
and so that deprecation stuff works properly.
…d removed to refer to content in different stages of removal
…on of contentctl that has not yet been merged or released in main branch.
…y_content into remove_detections
pyth0n1c
approved these changes
Mar 18, 2025
pyth0n1c
left a comment
pyth0n1c
left a comment
Collaborator
There was a problem hiding this comment.
I am approving. I discussed with @patel-bhavin and we came to a few points of agreement:
- If ONLY a status is changed for a file which does not use ES8 versioning, like baselines, a version bump does not need to happen.
- When something is moved from a deprecated/ folder into removed/ NOTHING should be updated. This includes the date and the version.
- There were a number of baselines we failed to tag for removal in 5.2.0. However, the detections which use them WERE tagged appropriately for removal. Since they are not uselful without the detections they support, they have been moved directly from production->removed without spending 2 releases in the deprecated state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.