Skip to content

fix: remote_utility typo in remote_access_software.csv - #3445

Merged
patel-bhavin merged 4 commits into
splunk:developfrom
sventec:patch-1
Apr 4, 2025
Merged

patel-bhavin merged 4 commits into
splunk:developfrom
sventec:patch-1

Conversation

@sventec

@sventec sventec commented Apr 4, 2025 •

Copy link
Copy Markdown
Contributor

Details

PR fixes a typo in the remote_access_software.csv lookup file. Executable name is currently NinjaRMMAgenPatcher.exe, PR corrects typo Agen --> Agent.

Additional fix added for .ese --> .exe for nxservice*.ese.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

@sventec

sventec commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

May require updates in the lookup's related YAML file, or other changes. I avoided making further changes there as I'm unsure on what exactly is required. Happy to adjust as needed, or just file this as an issue if that would be preferred.

@ljstella

ljstella commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Hey @sventec, thanks for the change!

Regarding your comment, if you could bump the version and date in remote_access_software.yml to go along with your change, that will ensure we generate a lookup with a new filename (needed for in-place upgrades of ESCU).

Comment thread lookups/remote_access_software.csv Outdated
@sventec

sventec commented Apr 4, 2025 •

Copy link
Copy Markdown
Contributor Author

Hey @sventec, thanks for the change!

Regarding your comment, if you could bump the version and date in remote_access_software.yml to go along with your change, that will ensure we generate a lookup with a new filename (needed for in-place upgrades of ESCU).

Thanks @ljstella, added that additional typo correction, and updated date & version in the associated YAML file. Appreciate the assistance wrt. the lookup update process!

@ljstella ljstella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patel-bhavin
patel-bhavin merged commit 31deacc into splunk:develop Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants