Skip to content

Deprecated Detect Large ICMP Traffic Based On .conf Telemetry - #4313

Merged
nasbench merged 7 commits into
developfrom
conf26_udpates
Oct 13, 2026
Merged

Deprecated Detect Large ICMP Traffic Based On .conf Telemetry#4313
nasbench merged 7 commits into
developfrom
conf26_udpates

Conversation

@patel-bhavin

@patel-bhavin patel-bhavin commented Oct 2, 2026 •
edited by nasbench
Loading

Copy link
Copy Markdown
Contributor

This PR deprecated Detect Large ICMP Traffic based on feedback obtained from .conf SOC telemetry

@nasbench nasbench added this to the v6.9.0 milestone Oct 5, 2026
nasbench
nasbench reviewed Oct 5, 2026
View reviewed changes
Comment thread detections/deprecated/detect_large_icmp_traffic.yml Outdated
@nasbench nasbench changed the title deprecating Deprecate Noisy Analytics Based On Telemetry Feedback Oct 5, 2026
@patel-bhavin
patel-bhavin marked this pull request as ready for review October 13, 2026 16:14
@patel-bhavin patel-bhavin changed the title Deprecate Noisy Analytics Based On Telemetry Feedback Analytics updates Based On .conf telemetry Oct 13, 2026
@patel-bhavin

patel-bhavin commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T16:53:39.047403Z 5078418 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 5078418d4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nasbench
nasbench reviewed Oct 13, 2026
View reviewed changes
Comment thread detections/web/detect_remote_access_software_usage_url.yml Outdated
NOT Web.url_domain IN (
"-",
"unknown"
"-", "unknown", "*tanium.com", "*tailscale.com", "*rapid7.com", "*sophos.com","*sophosupd.com","*beyondtrustcloud.com","*nordcdn.com","*amazonaws.com"

@nasbench nasbench Oct 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is no longer needed, since @onurmerdogan is changing the logic to leverage a lookup instead - See https://github.com/splunk/security_content/pull/4328/changes#diff-903092178090db05d6da7eeed46db2edae6c71f128cadaff35e926d1fb2afa40

I will revert this change and continue the discussion in the other PR

@nasbench nasbench changed the title Analytics updates Based On .conf telemetry Deprecated Detect Large ICMP Traffic Based On .conf Telemetry Oct 13, 2026
@nasbench
nasbench merged commit 6e6fe3b into develop Oct 13, 2026
6 checks passed
@nasbench
nasbench deleted the conf26_udpates branch October 13, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nasbench nasbench nasbench approved these changes
@ljstella ljstella Awaiting requested review from ljstella ljstella is a code owner
@pyth0n1c pyth0n1c Awaiting requested review from pyth0n1c pyth0n1c is a code owner
@RavenTait RavenTait Awaiting requested review from RavenTait RavenTait is a code owner
@tccontre tccontre Awaiting requested review from tccontre tccontre is a code owner
@rosplk rosplk Awaiting requested review from rosplk rosplk is a code owner
@P4T12ICK P4T12ICK Awaiting requested review from P4T12ICK P4T12ICK is a code owner
@onurmerdogan onurmerdogan Awaiting requested review from onurmerdogan onurmerdogan is a code owner

Assignees

No one assigned

Labels

Detections

Projects

None yet

Milestone

v6.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@patel-bhavin @nasbench