Repository navigation
Ryuk story and detections - #899
Merged
Merged
Conversation
Closed
rosplk
requested changes
Nov 9, 2020
rosplk
left a comment
rosplk
left a comment
Contributor
There was a problem hiding this comment.
Looks good to The search looks for files that contain the key word Ryuk under any folder in the C drive, which is consistent with Samsam ##changeto'ryuk'## propagation. how_to_implement: You must be ingesting data that records the file-system activity' this needs to be fixed this is Ryuk Test Files Detected
ghoto
reviewed
Nov 9, 2020
| output_path = path.join(OUTPUT_PATH, file_path) | ||
| if response_task['search'].find(">") is not -1: | ||
| if response_task['search'].find(">") != -1: | ||
| response_task['search']= response_task['search'].replace(">",">") |
Contributor
There was a problem hiding this comment.
I think the "if"'s here are redundant.
response_task['search']= response_task['search'].replace(">",">")
is going to replace ">" if it exists and leave it untouched if it doesn't.
Contributor
Author
There was a problem hiding this comment.
oh good point 😄 fixing.
rosplk
previously approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a new story:
adds new detections:
improved
validate.pyby adding additional logging