Skip to content

Release a new version? #788

Closed
Closed

Description

@kevinburke1

We keep getting stung by things that are fixed in master but not fixed in a tagged release. Any chance we can tag a release?

I have been using tip locally without any issues.

Activity

  1. kyleconroy commented on Nov 16, 2020

    @kyleconroy
    Collaborator

    Yes! The plan is to release the next version, now 2.0.0 due to MySQL breaking changes, this week. Sorry for the long wait.

  2. added this to the v1.6.0 milestone on Nov 16, 2020
  3. kyleconroy commented on Nov 19, 2020

    @kyleconroy
    Collaborator

    Welp, it's going to be v1.6.0 because Go module version is strange. But the version is coming soon!

  4. removed this from the v1.6.0 milestone on Nov 19, 2020
  5. EnchanterIO commented on Nov 22, 2020

    @EnchanterIO

    +1.

    I would also like to ask @kyleconroy, What would be the best way to include to sqlc in the Docker build process?

    I have a typical docker image like:

    WORKDIR /build
    
    ADD go.mod go.sum vendor ./
    
    ADD . .
    
    RUN CGO_ENABLED=0 GOOS=linux go build -mod vendor -a -installsuffix nocgo -o /manager ./manager
    

    BUT, now I would also like to perform the sqlc generate before building my program's binary.

    I was thinking about doing something like this:

    FROM golang:1.15.2-buster AS builder
    
    WORKDIR /go
    
    RUN go get -u github.com/tmthrgd/go-bindata
    RUN go get -u github.com/kyleconroy/sqlc/cmd/sqlc
    
    WORKDIR /build
    
    ADD go.mod go.sum vendor ./
    
    ADD . .
    
    // NOTICE THIS TO GENERATE QUERIES
    // NOTICE THIS TO GENERATE QUERIES
    // NOTICE THIS TO GENERATE QUERIES
    RUN sqlc generate
    RUN CGO_ENABLED=0 GOOS=linux go build -mod vendor -a -installsuffix nocgo -o /manager ./manager
    

    But this is failing atm right in the go get part for the master and I would like to lock sqlc to a specific version. 1.5.0 or this incoming 1.6.0.

     => ERROR [4/4] RUN go get github.com/kyleconroy/sqlc/cmd/sqlc                                                                                                                                                    90.1s
    ------                                                                                                                                                                                                                  
     > [4/4] RUN go get github.com/kyleconroy/sqlc/cmd/sqlc:                                                                                                                                                                
    #7 72.66 # github.com/kyleconroy/sqlc/internal/engine/dolphin                                                                                                                                                           
    #7 72.66 src/github.com/kyleconroy/sqlc/internal/engine/dolphin/convert.go:303:28: n.OldTable undefined (type *"github.com/pingcap/parser/ast".RenameTableStmt has no field or method OldTable)
    
    

    How would you recommend to include the sqlc in the docker building process please?

    Update:

    For now, it seems I got it working with:

    ADD https://github.com/kyleconroy/sqlc/releases/download/v1.5.0/sqlc-v1.5.0-linux-amd64.tar.gz ./
    RUN tar -xzf ./sqlc-v1.5.0-linux-amd64.tar.gz --directory ./bin/
    

    And then:

    RUN cd identities && sqlc generate
    RUN CGO_ENABLED=0 GOOS=linux go build -mod vendor -a -installsuffix nocgo -o /manager ./manager
    

    But not if there is a better way.

  6. kyleconroy commented on Nov 22, 2020

    @kyleconroy
    Collaborator

    @EnchanterIO I've moved your comment to a new discussion, hope that's okay.

  7. kevinburke1 commented on Nov 22, 2020

    @kevinburke1
    ContributorAuthor

    FWIW, we have Ubuntu sqlc packages available here https://packagecloud.io/app/meter/public/search?q=sqlc

  8. kyleconroy commented on Nov 23, 2020

    @kyleconroy
    Collaborator

    v1.6.0 has been tagged. My release script is currently broken, so I don't think it will land on brew, docker, etc. until tomorrow afternoon.

  9. kyleconroy commented on Nov 24, 2020

    @kyleconroy
    Collaborator

    Docker, Equinox, Homebrew, Snapcraft and GitHub releases are now all up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions