Skip to content

Move CSS in head #445

Open
Open

Description

@XhmikosR

This should allow us to make further optimizations (autoprefixer, minification etc).

Also, we could try moving the results CSS to a separate file so that it's cached, and keep the index page CSS inlined.

Just thinking out loud BTW :)

Another gain will be that we'll have one place to handle the CSS (minus the bars height/width and any other inline styles that cannot be moved of course)

Activity

  1. JB1905 commented on Nov 13, 2019

    @JB1905
    Contributor

    Hi!
    I also think that types of style should be unified.
    What about solutions such as Styled Components?

  2. styfle commented on Nov 13, 2019

    @styfle
    Owner

    Does it work with TypeScript? I want to catch typos in styles.

  3. JB1905 commented on Nov 13, 2019

    @JB1905
    Contributor

    Does it work with TypeScript? I want to catch typos in styles.

    It works only with props passed to styled component.
    https://www.styled-components.com/docs/api#typescript

    However, there is available stylelint extension for Styled Components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions