This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Don't rename require statements out of define scope #367
Description
When require is rescoped we need to no longer rename it. Issue reported in jspm/jspm#1221.
Activity
dmcnaugh commentedon Oct 24, 2015
This bug appears since jspm/jspm-cli 0.16.13 (possibly a typo in the original, linked issue post suggesting 0.16.3) pointing towards a change in systemjs-builder from 0.14.8 to 0.14.9
guybedford commentedon Oct 29, 2015
Fixed in 7b112e1.
guybedford commentedon Oct 31, 2015
Released in 0.14.10.
dmcnaugh commentedon Nov 1, 2015
I've looked at the generated bundle code and I don't believe this issued is correctly resolved.
With 0.14.10 all the references to 'require' are now consistently renamed to 'req' so there is no longer a runtime error from the bundle. But 'require' is still being renamed to 'req'.
Specifically this will cause a problem for any package that uses both 'req' and 'require' in the same scope. Having tested this, it causes bundle generation to fail.
In 0.14.9 the issue was that not all references to 'require' were consistently changed to 'req'. Prior to 0.14.9 I didn't see this happening.
guybedford commentedon Nov 1, 2015
@dmcnaugh thanks, yes this should be a more obscure name to avoid conflicts. I've added 86ecb73 to avoid this.