Builder fails silently once typescript is updated to 2.3.1+ #828

Activity

1. jamesbrobb commented on Jul 29, 2017

   

   jamesbrobb

   on Jul 29, 2017

   Author

   More actions

   I've tracked the issue down to here (as this verion of systemjs-builder currently uses systemjs 0.19.47):

   https://github.com/systemjs/systemjs/blob/0.19.47/dist/system.src.js#L3544

   It looks like something has changed in typescript 2.3.1 which means that it's now detected as esm by the esmRegEx. So the if block on line 3544 gets run, which in turn causes the builder to silently fail.

   I've forced the typescript source to not be detected as esm in my local version and everything works correctly and the build completes and outputs the file. But i'm afraid fixing the regex (or what's expected from it) is a bit beyond me.

   Took a while to work out, but at least this made me smile ;)

   good enough ES6 module detection regex - format detections not designed to be accurate, but to handle the 99% use case
2. aluanhaddad commented on Jul 29, 2017

   

   aluanhaddad

   on Jul 29, 2017

   More actions

   Use package or meta configuration to target typescript and specify format: "cjs". The better solution though is to use plugin-typescript.
3. jamesbrobb commented on Jul 29, 2017

   

   jamesbrobb

   on Jul 29, 2017

   Last edited by jamesbrobb

   Author

   More actions

   @aluanhaddad thanks for the quick response.

   Unfortunately setting the format to cjs (in either packages or meta) results in the following error:

   { Error on translate for main at file:///Users/blah/blah/project/src/main.ts
           (SystemJS) ENOENT: no such file or directory, open '/Users/blah/blah/project/src/fs'
           Error: ENOENT: no such file or directory, open '/Users/blah/blah/project/src/fs'
               at Error (native)
           Error loading /Users/blah/blah/project/src/fs as "fs" from /Users/blah/blah/project/node_modules/typescript/lib/typescript.js
           Unable to load transpiler to transpile /Users/blah/blah/project/src/main.ts
     originalErr: 
      { Error: ENOENT: no such file or directory, open '/Users/blah/blah/project/src/fs'
          at Error (native)
        errno: -2,
        code: 'ENOENT',
        syscall: 'open',
        path: '/Users/blah/blah/project/src/fs' } }
   
4. jamesbrobb commented on Jul 29, 2017

   

   jamesbrobb

   on Jul 29, 2017

   Author

   More actions

   Installing and configuring plugin-typescript fixed the issue, thanks

   👍React with 👍1Reacted by Aluan Haddad
5. aluanhaddad commented on Jul 30, 2017

   

   aluanhaddad

   on Jul 30, 2017

   More actions

   Yeah I forgot all of the other configuration that you need to add in addition to format.

   plugin-typescript helps handle that.

   I'm glad you got it working and I hope others find this discussion useful.

   👍React with 👍1Reacted by shohre