This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Sourcemap issue with beta.48 #849
Description
JSPM 0.17.0-beta.48 (Windows 10) seems to introduce issue woth sourcemaps.
Here is how it looks before beta.48 on Windows (note the issue with paths, described in #845):
{
"version": 3,
"sources": [
"jspm_packages/npm/jquery@3.3.1/dist/jquery.js",
"src/file:/J:/_DEL_JSPM_TEST/src/dep.js",
"src/file:/J:/_DEL_JSPM_TEST/src/app.js"
],
"names": [...],
"mappings": "...",
"file": "build.js"
}beta.48 fixed issue with paths on Windows, but now source map does not include package internal dependencies — only package itself and jspm_packages dependencies:
Here is how it looks with beta.48:
{
"version": 3,
"sources": [
"jspm_packages/npm/jquery@3.3.1/dist/jquery.js",
"src/app.js"
],
"names": [...],
"mappings": "...",
"file": "build.js"
}
Activity
ArmorDarks commentedon May 4, 2018
Archive with reproducted issue
guybedford commentedon May 4, 2018
Are you sure this isn't the result of tree-shaking removing use of the dependency entirely?
ArmorDarks commentedon May 4, 2018
Well, at least it shouldn't.
src/dep.jsexplicitly imported bysrc/app.jswithimport './dep, and final bundle has code fromdep.js, but just does not exist in sourcemapsHere is console output:
I also have another very large projects with good amount local package dependencies, and it has same issue — they all no longer appear in sourcemaps with beta.48.
guybedford commentedon May 4, 2018
Odd, perhaps Rollup is just not outputting source maps dependencies that have invalid file paths?
ArmorDarks commentedon May 4, 2018
Can't tell. The paths should be valid. I guess it would error about non-existing files if paths were invalid?
But I mostly certain it's an issue with Rollup.