Skip to content

Update workflows to test PR #600 refactor + rewrite injection regression for new API - #3

Open
MaddyMicrosoft wants to merge 2 commits into
teresaritorto:test_releasefrom
MaddyMicrosoft:test_release-add-injection-regression
Open

Update workflows to test PR #600 refactor + rewrite injection regression for new API#3
MaddyMicrosoft wants to merge 2 commits into
teresaritorto:test_releasefrom
MaddyMicrosoft:test_release-add-injection-regression

Conversation

@MaddyMicrosoft

Copy link
Copy Markdown

Two updates to align with PR Azure#600 (the pwsh -File refactor) on Azure/login:

testLogin.yml and real-login job in testLogin2.yml

testLogin2.yml — new jobs

  • run-unit-tests: runs the 30 unit tests (including the 6 SECURITY regression tests) from the same test-release SHA in a real runner
  • ps-injection-regression (rewritten): now calls the new getAzPSLoginInvocation() API (which returns {args, env} instead of a script string), wraps the real AzPSLogin.ps1 with mocked Connect-AzAccount and Add-AzEnvironment, and asserts that the adversarial payloads pass through as inert param() values without creating a marker file. Tests all four fields (tenant-id, subscription-id, client-id, resourceManagerEndpointUrl).

Feel free to merge, or let me know if you'd rather I hold. The workflow files are yours 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants