Support variable sized sortables #32

Activity

1. martinpengellyphillips commented on May 2, 2022

   

   martinpengellyphillips

   on May 2, 2022

   ContributorAuthor

   More actions

   For reference, this was the previous 'vertical' algorithm:

     const sortedTransform = (): Transform => {
       const delta = noopTransform();
       const resolvedInitialIndex = initialIndex();
       const resolvedCurrentIndex = currentIndex();
   
       if (
         !anyDraggableActive() ||
         resolvedCurrentIndex === resolvedInitialIndex
       ) {
         return delta;
       }
   
       const draggableId = dndState.active.draggable!;
       const draggableInitialIndex = sortableState.initialIds.indexOf(draggableId);
       const draggableLayout = layoutById(draggableId)!;
   
       if (draggable.isActiveDraggable) {
         const droppableId = dndState.active.droppable!;
         const droppableLayout = layoutById(droppableId)!;
         if (resolvedCurrentIndex > resolvedInitialIndex) {
           delta.y = droppableLayout.bottom - draggableLayout.bottom;
         } else {
           delta.y = droppableLayout.top - draggableLayout.top;
         }
       } else {
         if (resolvedCurrentIndex > resolvedInitialIndex) {
           const leadingId = sortableState.initialIds[draggableInitialIndex - 1];
           const leadingLayout = layoutById(leadingId)!;
           const leadingGap = draggableLayout.top - leadingLayout.bottom;
           delta.y += draggableLayout.height + leadingGap;
         } else {
           const trailingId = sortableState.initialIds[draggableInitialIndex + 1];
           const trailingLayout = layoutById(trailingId)!;
           const trailingGap = trailingLayout.top - draggableLayout.bottom;
           delta.y -= draggableLayout.height + trailingGap;
         }
       }
   
       return delta;
     };
2. alllex commented on Sep 23, 2022

   

   alllex

   on Sep 23, 2022

   Contributor

   More actions

   Very much looking forward to this!

   Currently, it's the only thing that seems to be not working for me. Here is how dragging looks for the variable-sized sortables with the flex flex-row items-center gap-1 Tailwind styles for the container.

   Screen.Recording.2022-09-24.at.00.45.30.mov
3. JoleMile commented on Nov 12, 2022

   

   JoleMile

   on Nov 12, 2022

   More actions

   Same here. Everything else is working great, but this makes things look quite ugly at times.
   Haven't looked into this much, but could we steal some logic from here https://master--5fc05e08a4a65d0021ae0bf2.chromatic.com/?path=/story/presets-sortable-vertical--variable-heights maybe?

   Would love to see this "fixed" soon.
   Thank you for making and maintaining this library.
4. martinpengellyphillips commented on Nov 19, 2022

   

   martinpengellyphillips

   on Nov 19, 2022

   ContributorAuthor

   More actions

   Thanks for the kind words.

   The logic you see in dnd-kit is similar to what I had before (see the example code at the top of this issue). However, I encountered some issues with it and will rethink the approach. Hopefully the overall improvements to the library I've made since will make this easier to solve :)

   👍React with 👍3Reacted by Josip Matijevic, cheech and bjoluc
5. cheechgodx commented on Jul 20, 2023

   

   cheechgodx

   on Jul 20, 2023

   More actions

   Hey. Lib is wonderful, but this issue is the first thing that catches your eye. Has anyone found any solution?