Skip to content

Follow-up from #894: retain a rejected close on the relay late-connect path #896

Open

Description

@tps-flint

Follow-up from the review of #894 (non-blocking), tracked here:

  1. A rejected close on the late-connect path is not retained. When a connection completes after stop() has begun, the relay closes it and swallows a rejected close() without retaining the channel, so stop() neither retries that close nor reports it. The fix retains the channel for stop()'s retry like the reconnect and graceful-disconnect paths, with a test where the late connection's first close rejects.

Refs #828, #894.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions