Error: Cannot read property 'type' of undefined

[eightysteele]

Describe the bug

Using tryfabric/notion-github-action@v1.2.1, creating a new GH issue fails to sync to Notion via the workflow action.

Steps to reproduce

1. Follow the setup
2. Create a new issue
3. Check the failed action

Expected behavior

A new Notion page created for the GH issue.

Additional context

This recently started failing. I upgraded to tryfabric/notion-github-action@v1.2.1 but it's still failing. Any sense for what might be going on? Thanks. :)

[markleung0905]

I'm having the same problem.

[eightysteele]

👋🏻 hello friends, curious if any updates on this one. thanks! :)

[PanicBear]

If I may, this problem would be solved with modifying value of argument!

• src/action.ts line 112
  • ASIS: function getBodyChildrenBlocks(body: string)
  • TODO: function getBodyChildrenBlocks(body?: string)

Reason I Think!

1. As I tested, this problem occurs when content of question is empty.
   Not comments only body of issues; we cannot post comment empty.

2. Before error shows up, I found this log printed.
   Querying database for page with github id...

3. There was single function, this log is written.

// src/action.ts Line 162
async function handleIssueEdited(options: IssueEditedOptions) {
  const {notion, payload, octokit} = options;

  core.info(`Querying database for page with github id ${payload.issue.id}`);

  const query = await notion.client.databases.query({
    database_id: notion.databaseId,
    filter: {
      property: 'ID',
      number: {
        equals: payload.issue.id,
      },
    },
    page_size: 1,
  });

  const bodyBlocks = getBodyChildrenBlocks(payload.issue.body);

4. And there was function right below this log, receiving content of body as string.

function getBodyChildrenBlocks(body: string): Exclude<CreatePageParameters['children'], undefined> {
  // We're currently using only one paragraph block, but this could be extended to multiple kinds of blocks.
  return [
    {
      type: 'paragraph',
      paragraph: {
        text: parseBodyRichText(body),
      },
    },
  ];
}

---

This is my first comment of github community,
so I hope you don't get mad if it doesn't work..

[PanicBear]

@EndBug Would you kindly considerate upper comment?

[EndBug]

Hi @PanicBear
Fabric has closed, and so there is no staff doing active maintenance on these repos.
If you have any changes you'd like to see in the action, feel free to fork and test them on your own. If they work you're welcome to open a PR and tag me there, I'll take a look ;)

[eightysteele]

sorry to hear that fabric closed! for those following along, the latest version of notion supports syncing with github: https://www.notion.so/help/guides/synced-databases-bridge-different-tools