Repository navigation
[v5] sourceKey missing from HasOneOptions #175
Description
I previously submitted issue #29414 for v4 that scope was missing from AssociationOptionsBelongsTo and sourceKey was missing from AssociationOptionsHasOne.
It looks like BelongsToOptions now has scope (inherited from AssociationOptions), so that is fixed. However sourceKey is still missing from HasOneOptions. It probably needs to be added to AssociationOptions as well, but I'll let you guys decide that.
I'm working with some legacy databases and I'm broken without this. Worse, I can't seem to patch it locally with declare module overrides as I could in v4, now that the typings are distributed in different files. Any help there appreciated; my typescript experience is ... modest.
Thanks,
-Billy
Activity
[-]sourceKey missing from HasOneOptions[/-][+][v5] sourceKey missing from HasOneOptions[/+]billybarnum commentedon Nov 11, 2018
This is a pretty easy fix so I went ahead and fixed it locally on my box. I elected to add sourceKey to AssociationOptions since sourceKey applies to more than one type of association.
However, I don't have write access to the repo and I can't push it up. I've never made a PR to a public repo before; what's the procedure? Do I really submit a PR from a fork, or do you guys grant me access, or ... ?